Skip to content

fix(apollo-forest-run): index covered operations#661

Merged
vladar merged 3 commits intomainfrom
vladar/forest-run-covers-perf-fix
Apr 13, 2026
Merged

fix(apollo-forest-run): index covered operations#661
vladar merged 3 commits intomainfrom
vladar/forest-run-covers-perf-fix

Conversation

@vladar
Copy link
Copy Markdown
Contributor

@vladar vladar commented Apr 10, 2026

Fix a minor perf regression in ForestRun affecting slow-path reads (related to #642).

Before: ForestRun redundantly loops through all operations in the forest to detect covered operations
After: tracks covered operations in a Map, allowing faster lookups (avoids looping through all operations)

@github-actions
Copy link
Copy Markdown

📊 Benchmark Analysis Report

🔍 Found 3 significant change(s)

🎯 Same Configuration Comparisons

Comparing against baseline with the same cache configuration

Benchmark ID Configuration Execution Memory
write-no-changes_0 Default 🟢 4398.12 bytes → 3710.00 bytes (-15.6%)
modify-affecting-0-objects_0 Default 🟢 3844.23 bytes → 3442.04 bytes (-10.5%)
modify-affecting-0-objects_50 Default 🟢 10517.43 ns → 9812.66 ns (-6.7%)

Threshold: 5% change


Updated: 2026-04-10T17:48:13.610Z

@vladar vladar marked this pull request as ready for review April 13, 2026 09:30
@vladar vladar merged commit edf2e48 into main Apr 13, 2026
8 of 10 checks passed
@vladar vladar deleted the vladar/forest-run-covers-perf-fix branch April 13, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants