fix(json): remove redundant guard in get_child_node#560
Merged
Conversation
Remove early guard rasing ValueError on an empty identifier. The lookup is performed as usual allowing the method to return None. Fixes microsoft#559 Signed-off-by: Giorgos Siantikos <gsiantikos@i4.energy>
gntikos
force-pushed
the
fix/get-child-node-empty-input
branch
from
May 28, 2026 04:06
01f2298 to
1230131
Compare
Contributor
Author
|
@microsoft-github-policy-service agree company="i4energy" |
baywet
requested changes
May 28, 2026
Signed-off-by: Giorgos Siantikos <gsiantikos@i4.energy>
|
baywet
approved these changes
May 28, 2026
baywet
left a comment
baywet
left a comment
Member
There was a problem hiding this comment.
Thank you for making the changes!
baywet
enabled auto-merge (squash)
May 28, 2026 12:59
baywet
disabled auto-merge
May 28, 2026 12:59
baywet
enabled auto-merge
May 28, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Removes an identified guard in
get_child_node. The guard does not really protect from anything, but breaks generated code, for example in cases ofoneOfwithout discriminator (seemicrosoft/kiota#6868).The method now returns
None, which is allowed since the return type isOptional[ParseNode].Related Issue
Fixes #559