Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Kiota.Builder/Refiners/PhpRefiner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ public override Task RefineAsync(CodeNamespace generatedCode, CancellationToken
CodePropertyKind.QueryParameter,
},
static s => s.ToCamelCase(UnderscoreArray));
AddDefaultImports(generatedCode, queryParameterUsingEvaluators);
}, cancellationToken);
}
private static readonly Dictionary<string, (string, CodeUsing?)> DateTypesReplacements = new(StringComparer.OrdinalIgnoreCase)
Expand Down Expand Up @@ -212,13 +213,19 @@ public override Task RefineAsync(CodeNamespace generatedCode, CancellationToken
new(static x => x is CodeProperty {Type.Name: {}} property && property.Type.Name.Equals("DateTime", StringComparison.OrdinalIgnoreCase), "", "\\DateTime"),
new(static x => x is CodeProperty {Type.Name: {}} property && property.Type.Name.Equals("DateTimeOffset", StringComparison.OrdinalIgnoreCase), "", "\\DateTime"),
new(static x => x is CodeMethod method && method.IsOfKind(CodeMethodKind.ClientConstructor), AbstractionsNamespaceName, "ApiClientBuilder"),
new(static x => x is CodeProperty property && property.IsOfKind(CodePropertyKind.QueryParameter) && !string.IsNullOrEmpty(property.SerializationName), AbstractionsNamespaceName, "QueryParameter"),
new(static x => x is CodeClass codeClass && codeClass.IsOfKind(CodeClassKind.RequestConfiguration), AbstractionsNamespaceName, "RequestOption"),
new (static x => x is CodeClass { OriginalComposedType: CodeIntersectionType intersectionType } && intersectionType.Types.Any(static y => !y.IsExternal),
$@"{AbstractionsNamespaceName}\Serialization", "ParseNodeHelper"),
new (static x => x is CodeMethod method && method.IsOfKind(CodeMethodKind.RequestExecutor, CodeMethodKind.RequestGenerator) && method.Parameters.Any(static y => y.IsOfKind(CodeParameterKind.RequestBody) && y.Type.Name.Equals(MultipartBodyClassName, StringComparison.OrdinalIgnoreCase)),
AbstractionsNamespaceName, MultipartBodyClassName)
};
private static readonly AdditionalUsingEvaluator[] queryParameterUsingEvaluators = {
new(static x => x is CodeProperty property &&
property.IsOfKind(CodePropertyKind.QueryParameter) &&
!string.IsNullOrEmpty(property.SerializationName),
AbstractionsNamespaceName,
"QueryParameter"),
};

private const string MultipartBodyClassName = "MultiPartBody";

Expand Down Expand Up @@ -473,4 +480,3 @@ private static void AddQueryParameterFactoryMethod(CodeElement codeElement)
CrawlTree(codeElement, AddQueryParameterFactoryMethod);
}
}

27 changes: 27 additions & 0 deletions tests/Kiota.Builder.Tests/Refiners/PhpLanguageRefinerTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,33 @@ public async Task AddsDefaultImportsAsync()
Assert.NotEmpty(model.StartBlock.Usings);
}

[Fact]
public async Task AddsQueryParameterImportAfterRenamingAsync()
{
var queryParameters = root.AddClass(new CodeClass
{
Name = "ThingsRequestBuilderGetQueryParameters",
Kind = CodeClassKind.QueryParameters,
}).First();
var property = queryParameters.AddProperty(new CodeProperty
{
Name = "category_id",
Kind = CodePropertyKind.QueryParameter,
Type = new CodeType { Name = "string" },
}).First();

await ILanguageRefiner.RefineAsync(
new GenerationConfiguration { Language = GenerationLanguage.PHP },
root,
cancellationToken: TestContext.Current.CancellationToken);

Assert.Equal("categoryId", property.Name);
Assert.Equal("category_id", property.SerializationName);
Assert.Contains(queryParameters.StartBlock.Usings, static x =>
x.Name.Equals("QueryParameter", System.StringComparison.Ordinal) &&
x.Declaration?.Name.Equals(@"Microsoft\Kiota\Abstractions", System.StringComparison.Ordinal) is true);
}

[Fact]
public async Task AddsExceptionInheritanceOnErrorClassesAsync()
{
Expand Down