This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Support configuring domain name of the load balancer#40
Open
norshtein wants to merge 2 commits intomicrosoft:masterfrom
Open
Support configuring domain name of the load balancer#40norshtein wants to merge 2 commits intomicrosoft:masterfrom
norshtein wants to merge 2 commits intomicrosoft:masterfrom
Conversation
bingosummer
suggested changes
Dec 3, 2018
Collaborator
bingosummer
left a comment
There was a problem hiding this comment.
kl analyzeshould generate the domain name label to make it unique. I think, there's no need to ask users to input it. They can overwrite it manually. If users do care about it, they may want to use their custom domain, which may need Azure DNS zone. That's a different story. Wdyt? @norshtein @andyliuliming- @norshtein please add the domain name into the VM's network outputs in
vm.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve (a part of?) #36 .
Support config domain name of the load balancer. Users can config the domain name by setting
domain_namein the load balancer field in the manifest. An example:However, I'm not very clear about when to edit this field in our workflow. Obviously, we can't give a default value in buildinmanifests, since domain name should be unique across an Azure region. Maybe we should also generate a patch file and remind the user to fill in the patch file?
Feel free to contact me at any time.
CC: @andyliuliming