Fix issue with decoding truncated files that were compressed with Rust in 0.5.5#179
Merged
Conversation
Test Results190 tests +7 190 ✅ +7 25m 43s ⏱️ +13s Results for commit cd572a1. ± Comparison against base commit f2501a8. This pull request removes 22 and adds 29 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
1570c2b to
7ae6ba2
Compare
MarioszMSFT
approved these changes
Jan 26, 2026
MarioszMSFT
approved these changes
Jan 26, 2026
gbrovman
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the regression in decoding in 0.5.5 (fixed 0.5.6 and later) it is possible in some rare cases that the compression succeeded despite creating a invalid LEP file, ie one that cannot be decompressed correctly by any other version of client (although it can be decompressed by 0.5.5 version). This is because of the roundtrip verification, which would have succeeded with the 0.5.5 code, but not with any other version.
Added special handling for files produced by these versions so that they are decompressed correctly.
Also updated version to 5.8 and made individual config files refer to the workspace version so we don't need to update all the toml files every time we bump the version.