Add trace_fs feature gate for conditional DebugLogProvider bound#760
Add trace_fs feature gate for conditional DebugLogProvider bound#760
Conversation
Add trace_fs feature to litebox Cargo.toml. When enabled (without lock_tracing), RawSyncPrimitivesProvider additionally requires DebugLogProvider, allowing filesystem tracing code to log through the platform's debug output.
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
jaybosamiya-ms
added
the
expmt:shadow-kiln
There was a problem hiding this comment.
I'm not sure that the explanation here for trace_fs makes sense. What is happening with the file system tracing? I see nothing in the file system implementations as part of this PR, so there is literally no context to this flag.
Adding new conditional-compilation flags increases testing/development/etc. complexity, so I am gonna say no to merging this PR unless very clear/strong evidence is shown for why it is needed.
My best guess is that this was part of some local testing code of whatever you were debugging and the agent split it out without realizing that it should actually remove the local testing code?
2 participants
Summary
trace_fsfeature tolitebox/Cargo.toml.DebugLogProviderbound onRawSyncPrimitivesProviderbehind#[cfg(feature = "trace_fs")], so platforms that don't need filesystem tracing can avoid the dependency.Split from #743.