Open
Conversation
Closed
jaybosamiya-ms
force-pushed
the
jayb/litebox-logging
branch
from
50f5f7d to
5c8d672
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is (effectively) a re-spin of #558. It resolves #171.
The previous PR (#558) introduced
tracingdirectly. In contrast here, we are using the #665 facade insideliteboxitself.This means that by-default
liteboxuses the lighter-weightlog, which is more suitable for embedded-ish kernel projects. Runners that wish to have the heavier-weighttracingcan flip the config flag (this is all primarily due to the work put into #665, this PR is mostly just realizing it).At the runner, this PR uses
tracing_subscriberdirectly and flips the config flag, which gives pretty output :)