Skip to content

Finish migration to litebox_util_log + remove DebugLogProvider#776

Open
jaybosamiya-ms wants to merge 2 commits intojayb/subscribers-for-runnersfrom
jayb/remove-debuglogprovider
Open

Finish migration to litebox_util_log + remove DebugLogProvider#776
jaybosamiya-ms wants to merge 2 commits intojayb/subscribers-for-runnersfrom
jayb/remove-debuglogprovider

Conversation

@jaybosamiya-ms
Copy link
Copy Markdown
Member

This PR removes DebugLogProvider entirely by switching all the direct and indirect uses of it for logging to the litebox_util_log crate introduced in #665.

@jaybosamiya-ms
Copy link
Copy Markdown
Member Author

Most of this is quite straightforward, but the repeated :% = format_args!(...) pattern makes me think I should update litebox_util_log to support :x or similar to easily get the hex output, rather than needing this pattern. I'm not doing that in this particular PR though.

@jaybosamiya-ms jaybosamiya-ms marked this pull request as ready for review April 14, 2026 23:08
@github-actions
Copy link
Copy Markdown

ℹ️ Note: This semver check was run against the jayb/subscribers-for-runners branch, not main.

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details
--- failure declarative_macro_missing: macro_rules declaration removed or renamed ---

Description:
A `macro_rules!` declarative macro cannot be invoked by its prior name. The macro may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/reference/macros-by-example.html#path-based-scope
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/declarative_macro_missing.ron

Failed in:
  macro log_println, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-jayb_subscribers_for_runners/0e3f50ac28a1d7f7bcd29d92f38f3ad3d9e045bb/litebox/src/platform/mod.rs:24

--- failure trait_missing: pub trait removed or renamed ---

Description:
A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_missing.ron

Failed in:
  trait litebox::platform::DebugLogProvider, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-jayb_subscribers_for_runners/0e3f50ac28a1d7f7bcd29d92f38f3ad3d9e045bb/litebox/src/platform/mod.rs:443

--- failure trait_removed_supertrait: supertrait removed or renamed ---

Description:
A supertrait was removed from a trait. Users of the trait can no longer assume it can also be used like its supertrait.
        ref: https://doc.rust-lang.org/reference/items/traits.html#supertraits
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_removed_supertrait.ron

Failed in:
  supertrait litebox::platform::DebugLogProvider of trait Provider in file /home/runner/work/litebox/litebox/litebox/src/platform/mod.rs:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant