Skip to content

[TaskExecutor] Adds extra SQLException logging on error #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
netonjm wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[TaskExecutor] Adds extra SQLException logging on error #159

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cbb35fa
[TaskExecutor] Adds extra SQLException logging on error
netonjm Oct 20, 2023
3706cfb
Fixes indentation
netonjm Oct 23, 2023
4f87daa
Merge branch 'main' into sql-error
anjagruenheid Oct 24, 2023
b333589
Minor fixes
netonjm Oct 24, 2023
f44e714
Insert specific sql property values before error message
netonjm Oct 24, 2023
bb7dc7e
Merge branch 'main' into sql-error
anjagruenheid Oct 30, 2023
56b0ffc
Merge branch 'main' into sql-error
anjagruenheid Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/main/java/com/microsoft/lst_bench/task/TaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import com.microsoft.lst_bench.telemetry.ImmutableEventInfo;
import com.microsoft.lst_bench.telemetry.SQLTelemetryRegistry;
import com.microsoft.lst_bench.util.StringUtils;
import java.sql.SQLException;
import java.time.Instant;
import java.util.Map;
import org.slf4j.Logger;
Expand Down Expand Up @@ -97,9 +98,20 @@ public void executeTask(Connection connection, TaskExec task, Map<String, Object
"Exception executing statement: "
+ statement.getId()
+ ", statement text: "
+ statement.getStatement()
+ "; error message: "
+ e.getMessage();
+ statement.getStatement();

// sql server driver exception messages
if (e instanceof SQLException) {
SQLException sqlException = (SQLException) e;
loggedError +=
"; SQL State: "
+ sqlException.getSQLState()
+ "; Error Code: "
+ sqlException.getErrorCode();
}

loggedError += "; Error message: " + e.getMessage();

for (String skipException : exceptionStrings) {
if (e.getMessage().contains(skipException)) {
LOGGER.warn(loggedError);
Expand Down