Merged
Conversation
Lets non-title sections use collapsibles
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the collapsible section functionality to separate title generation from collapsible content management. Previously, start_collapsible() automatically generated both a markdown header and collapsible HTML tags. Now, titles are handled separately with add_title() while start_collapsible() focuses solely on creating collapsible sections with customizable summary text.
- Splits title generation from collapsible section creation
- Updates
start_collapsible()to accept a summary parameter instead of title and level - Converts all report sections to use the new two-step pattern
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcp_interviewer/reports/base.py | Refactors start_collapsible() method to accept summary text and removes automatic title generation |
| src/mcp_interviewer/reports/server/tools.py | Updates to use separate add_title() and start_collapsible() calls |
| src/mcp_interviewer/reports/server/resources.py | Updates to use separate add_title() and start_collapsible() calls |
| src/mcp_interviewer/reports/server/resource_templates.py | Updates to use separate add_title() and start_collapsible() calls |
| src/mcp_interviewer/reports/server/prompts.py | Updates to use separate add_title() and start_collapsible() calls |
| src/mcp_interviewer/reports/interviewer/interviewer_info.py | Updates to use separate add_title() and start_collapsible() calls |
| src/mcp_interviewer/reports/functional_test/tool_scorecards.py | Updates to use separate add_title() and start_collapsible() calls |
| src/mcp_interviewer/reports/functional_test/test.py | Updates to use separate add_title() and start_collapsible() calls |
| mcp-interview.md | Test output file with updated content reflecting the changes |
| mcp-interview.json | Test data file with updated tool and test information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets non-title sections use collapsibles