Skip to content

Split title logic from collapsible#29

Merged
tylerpayne merged 1 commit intomainfrom
reports/collapsible
Oct 11, 2025
Merged

Split title logic from collapsible#29
tylerpayne merged 1 commit intomainfrom
reports/collapsible

Conversation

@tylerpayne
Copy link
Collaborator

Lets non-title sections use collapsibles

Lets non-title sections use collapsibles
@tylerpayne tylerpayne requested a review from Copilot October 11, 2025 16:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the collapsible section functionality to separate title generation from collapsible content management. Previously, start_collapsible() automatically generated both a markdown header and collapsible HTML tags. Now, titles are handled separately with add_title() while start_collapsible() focuses solely on creating collapsible sections with customizable summary text.

  • Splits title generation from collapsible section creation
  • Updates start_collapsible() to accept a summary parameter instead of title and level
  • Converts all report sections to use the new two-step pattern

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/mcp_interviewer/reports/base.py Refactors start_collapsible() method to accept summary text and removes automatic title generation
src/mcp_interviewer/reports/server/tools.py Updates to use separate add_title() and start_collapsible() calls
src/mcp_interviewer/reports/server/resources.py Updates to use separate add_title() and start_collapsible() calls
src/mcp_interviewer/reports/server/resource_templates.py Updates to use separate add_title() and start_collapsible() calls
src/mcp_interviewer/reports/server/prompts.py Updates to use separate add_title() and start_collapsible() calls
src/mcp_interviewer/reports/interviewer/interviewer_info.py Updates to use separate add_title() and start_collapsible() calls
src/mcp_interviewer/reports/functional_test/tool_scorecards.py Updates to use separate add_title() and start_collapsible() calls
src/mcp_interviewer/reports/functional_test/test.py Updates to use separate add_title() and start_collapsible() calls
mcp-interview.md Test output file with updated content reflecting the changes
mcp-interview.json Test data file with updated tool and test information

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tylerpayne tylerpayne merged commit 6830988 into main Oct 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants