Merged
Conversation
Use a table for summary, add line per passed constraint and line per violation in collapsible
Contributor
There was a problem hiding this comment.
Pull Request Overview
Cleanup and enhancement of the constraint violations report to improve readability and organization. The changes replace the previous text-based summary with a structured table format and reorganize the constraint details into a more systematic presentation.
- Replace text-based summary with a clear table showing errors, warnings, and passes
- Reorganize constraint presentation to show all constraints (both passing and failing) in a consistent format
- Simplify the collapsible section structure by removing nested collapsibles
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/mcp_interviewer/reports/interviewer/constraint_violations.py | Refactored report generation to use table format for summary and improved constraint organization |
| mcp-interview.md | Updated report output showing the new table format and reorganized constraint details |
| mcp-interview.json | Updated test data and expectations to reflect changes in report structure and tool behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/mcp_interviewer/reports/interviewer/constraint_violations.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a table for summary, add line per passed constraint and line per violation in collapsible