Merged
Conversation
…ints By providing sources to the constraints, users can follow links to see _why_ a constraint violation is not beneficial to downstream agents
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a sources field to the Constraint class to enable linking constraint violations to relevant documentation. Users can now follow links to understand why specific constraint violations are problematic for downstream agents.
Key changes:
- Added
sources()method to base Constraint class returning list of source URLs - Implemented source URLs for OpenAI and tool schema constraints
- Modified constraint violation reporting to display source links as numbered references
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mcp_interviewer/constraints/base.py | Adds SourceUrl type alias and sources() method to Constraint base class |
| src/mcp_interviewer/constraints/openai.py | Implements sources() method for OpenAI-related constraints with documentation links |
| src/mcp_interviewer/constraints/tool_schema_flatness.py | Implements sources() method for tool schema flatness constraint |
| src/mcp_interviewer/reports/interviewer/constraint_violations.py | Updates constraint violation display to include numbered source links |
| mcp-interview.md | Updated test results showing constraint violations with source references |
| mcp-interview.json | Updated test data with source link formatting changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By providing sources to the constraints, users can follow links to see why a constraint violation is not beneficial to downstream agents