Skip to content

Add Constraint.sources field#31

Merged
tylerpayne merged 1 commit intomainfrom
constraints/sources
Oct 11, 2025
Merged

Add Constraint.sources field#31
tylerpayne merged 1 commit intomainfrom
constraints/sources

Conversation

@tylerpayne
Copy link
Collaborator

By providing sources to the constraints, users can follow links to see why a constraint violation is not beneficial to downstream agents

…ints

By providing sources to the constraints, users can follow links to see _why_ a constraint violation is not beneficial to downstream agents
@tylerpayne tylerpayne requested a review from Copilot October 11, 2025 17:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a sources field to the Constraint class to enable linking constraint violations to relevant documentation. Users can now follow links to understand why specific constraint violations are problematic for downstream agents.

Key changes:

  • Added sources() method to base Constraint class returning list of source URLs
  • Implemented source URLs for OpenAI and tool schema constraints
  • Modified constraint violation reporting to display source links as numbered references

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/mcp_interviewer/constraints/base.py Adds SourceUrl type alias and sources() method to Constraint base class
src/mcp_interviewer/constraints/openai.py Implements sources() method for OpenAI-related constraints with documentation links
src/mcp_interviewer/constraints/tool_schema_flatness.py Implements sources() method for tool schema flatness constraint
src/mcp_interviewer/reports/interviewer/constraint_violations.py Updates constraint violation display to include numbered source links
mcp-interview.md Updated test results showing constraint violations with source references
mcp-interview.json Updated test data with source link formatting changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tylerpayne tylerpayne merged commit 96f6161 into main Oct 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants