Using vs17 for compilation going forward#1570
Merged
Conversation
gargsaumya
approved these changes
Feb 9, 2026
bewithgaurav
approved these changes
Feb 9, 2026
David-Engel
previously requested changes
Feb 9, 2026
Collaborator
David-Engel
left a comment
David-Engel
left a comment
There was a problem hiding this comment.
I'm guessing the real purpose of this PR was to get the pipelines running a bit faster to address the macOS job 60 minute timeout failures. That was accomplished by the infinite job timeout of 0 (we should just bump that up incrementally, not to infinite). The brew and git changes might save a minute or two. The vs17-noly compilation won't save any time in the macOS job. I think that change is a bit premature unless PHP 8.3 can also be compiled by vs17.
gargsaumya
approved these changes
Feb 10, 2026
bewithgaurav
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the logic for determining the compiler version in the
buildscripts/buildtools.pyscript. The function now always sets the compiler tovs17instead of selecting it based on the PHP version.Build tools logic simplification:
compiler_versionmethod inbuildscripts/buildtools.pywas updated to always setself.vcto'vs17', removing the previous conditional logic that selected the compiler based on the PHP version.