Skip to content

Speed up tests targeting invalid servers #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
David-Engel wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Speed up tests targeting invalid servers #1622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12eb751
Lower LoginTimeout in tests against invalid servers to reduce test time
David-Engel May 12, 2026
e5fbee3
Slightly increase logintimeout
David-Engel May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/functional/pdo_sqlsrv/PDO21_Connection.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ try {
// Invalid connection attempt => errors are expected
$serverName="InvalidServerName";

$dsn = getDSN($serverName, $databaseName, $driver);
$dsn = getDSN($serverName, $databaseName, $driver, 'LoginTimeout=1');
$conn1 = new PDO($dsn, $uid, $pwd, $connectionOptions);
if ($conn1) {
printf("Invalid connection attempt should have failed.\n");
Expand Down
4 changes: 2 additions & 2 deletions test/functional/pdo_sqlsrv/pdo_azure_ad_managed_identity.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function connectInvalidServer()
unset($conn);

// Try connecting to an invalid server, should get an exception from ODBC
$connectionInfo = "Authentication = ActiveDirectoryMsi;";
$connectionInfo = "Authentication = ActiveDirectoryMsi; LoginTimeout = 3;";
$testCase = 'invalidServer';
try {
$conn = new PDO("sqlsrv:server = invalidServer; $connectionInfo", null, null);
Expand Down Expand Up @@ -67,7 +67,7 @@ function connectInvalidServerWithUser()
unset($conn);

// Try connecting to an invalid server, should get an exception from ODBC
$connectionInfo = "Authentication = ActiveDirectoryMsi;";
$connectionInfo = "Authentication = ActiveDirectoryMsi; LoginTimeout = 3;";
$user = "user";
$testCase = 'invalidServer';
try {
Expand Down
2 changes: 1 addition & 1 deletion test/functional/pdo_sqlsrv/pdo_construct_attr_errors.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function invalidServer()
try {
$options = array(PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION);
$invalid = pack("H*", "ffc0");
$conn = new PDO("sqlsrv:server = $invalid; Encrypt = $encrypt;", $uid, $pwd, $options);
$conn = new PDO("sqlsrv:server = $invalid; Encrypt = $encrypt; LoginTimeout = 1;", $uid, $pwd, $options);
echo "Should have failed to connect to invalid server.\n";
} catch (PDOException $e) {
$error1 = '*Login timeout expired';
Expand Down
2 changes: 1 addition & 1 deletion test/functional/sqlsrv/TC21_Connection.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function connectionTest()
setup();

// Invalid connection attempt => errors are expected
$conn1 = sqlsrv_connect('InvalidServerName');
$conn1 = sqlsrv_connect('InvalidServerName', array('LoginTimeout' => 1));
if ($conn1 === false) {
handleErrors();
} else {
Expand Down
2 changes: 1 addition & 1 deletion test/functional/sqlsrv/sqlsrv_azure_ad_managed_identity.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function connectInvalidServer()
sqlsrv_close($conn);

// Try connecting to an invalid server, should get an exception from ODBC
$connectionInfo = array("Authentication"=>"ActiveDirectoryMsi");
$connectionInfo = array("Authentication"=>"ActiveDirectoryMsi", "LoginTimeout" => 1);
$conn = sqlsrv_connect('invalidServer', $connectionInfo);
if ($conn) {
fatalError("AzureAD Managed Identity test: expected to fail with invalidServer\n");
Expand Down
2 changes: 1 addition & 1 deletion test/functional/sqlsrv/sqlsrv_azure_ad_service_principal.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function connectAzureDB($showException)
}

// Try connecting to an invalid server. Expect this to fail.
$connectionInfo = array("Authentication"=>"ActiveDirectoryServicePrincipal");
$connectionInfo = array("Authentication"=>"ActiveDirectoryServicePrincipal", "LoginTimeout" => 1);
$conn = sqlsrv_connect('invalidServer', $connectionInfo);
if ($conn) {
fatalError("AzureAD Service Principal test: expected to fail with invalidServer\n");
Expand Down
2 changes: 1 addition & 1 deletion test/functional/sqlsrv/sqlsrv_connStr.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ sqlsrv_close($c);

// test an invalid server name in UTF-8
$server_invalid = pack("H*", "ffc0");
$c = sqlsrv_connect($server_invalid, array( 'Database' => 'test', 'CharacterSet' => 'utf-8' ));
$c = sqlsrv_connect($server_invalid, array( 'Database' => 'test', 'CharacterSet' => 'utf-8', 'LoginTimeout' => 1 ));
if ($c !== false) {
fatalError("sqlsrv_connect(1) should have failed");
}
Expand Down
2 changes: 1 addition & 1 deletion test/functional/sqlsrv/sqlsrv_errors.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ sqlsrv_close returns true even if an error happens.

require('MsCommon.inc');

$conn = sqlsrv_connect("InvalidServerName", array( "Database" => "test" ));
$conn = sqlsrv_connect("InvalidServerName", array( "Database" => "test", "LoginTimeout" => 1 ));
try {
$result = sqlsrv_close($conn);
if ($result !== false) {
Expand Down
Loading