-
Notifications
You must be signed in to change notification settings - Fork 36
FIX: Use imageOverride demand instead of vmImage for 1ES Windows pool selection #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates OneBranch/1ES pipeline pool configuration so Windows stages/jobs correctly select the custom hosted pool image via demands (imageOverride) instead of vmImage, avoiding the 1ES template validation failure and preventing fallback to the pool default image.
Changes:
- Replaced
vmImage: WIN22-SQL22withdemands: - imageOverride -equals WIN22-SQL22in the Windows build stage template. - Applied the same pool image selection change to both the official and dummy release pipelines.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| OneBranchPipelines/stages/build-windows-single-stage.yml | Switches Windows build job pool image selection to demands/imageOverride for the custom 1ES pool. |
| OneBranchPipelines/official-release-pipeline.yml | Updates the release job’s custom pool configuration to use imageOverride demand for WIN22-SQL22. |
| OneBranchPipelines/dummy-release-pipeline.yml | Updates the dummy release job’s custom pool configuration to use imageOverride demand for WIN22-SQL22. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
saurabh500
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is it possible to have a successful run link or does this PR need to be merged to test the OB ?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.logger_bridge.hpp: 58.8%
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.row.py: 66.2%
mssql_python.pybind.ddbc_bindings.cpp: 69.3%
mssql_python.pybind.ddbc_bindings.h: 69.7%
mssql_python.pybind.connection.connection.cpp: 75.3%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 84.1%
mssql_python.cursor.py: 84.7%🔗 Quick Links
|
With this PR, it would need to be merged first, then synced with ADO, and after that we can run the Official Build pipeline on the latest main. In the meantime, I’m creating a test PR with the same changes directly in ADO and will run the build on that test branch. This should allow us to validate OB more quickly while this original PR process completes. |
Work Item / Issue Reference
AB#42368
Summary
Fix 1ES Pipeline Templates validation failure (
1ES PT Error: Using an image without 1es-pt-prerequisites artifact is not allowed) on Windows build stages.The
Django-1ES-poolcustom 1ES Hosted Pool was falling back to its defaultMMS2016(Windows Server 2019) image becausevmImagedoesn't properly select images from custom pools. Changed all three Windows pool configurations to usedemandswithimageOverride(matching the pattern already used by the Linux stage template) to correctly select theWIN22-SQL22image.Files changed:
OneBranchPipelines/stages/build-windows-single-stage.ymlOneBranchPipelines/official-release-pipeline.ymlOneBranchPipelines/dummy-release-pipeline.yml