Record-Trace: Enable duration and memory limits#291
Merged
Conversation
This was
linked to
issues
Jun 15, 2026
We have scenarios where record-trace should automatically stop as if a user hit control-c when either a duration or memory limit is hit. Add --duration and --max-memory arguments to allow these scenarios. Honor duration within the parse_until callback directly. Spawn a thread for memory monitoring, using OS specific functions. This ensures that memory monitoring does not affect the consumer threads ability to keep up with data rates. Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com>
beaubelgrave
force-pushed
the
users/beaub/mem_time_record_args
branch
from
5e80e2d to
cf850b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have scenarios where record-trace should automatically stop as if a user hit control-c when either a duration or memory limit is hit.
Add --duration and --max-memory arguments to allow these scenarios.
Honor duration within the parse_until callback directly.
Spawn a thread for memory monitoring, using OS specific functions. This ensures that memory monitoring does not affect the consumer threads ability to keep up with data rates.
Tested on both Windows and Linux manually for both --duration and --max-memory arguments, ensuring they stopped the trace at the correct points.