Add --session-name flag to record-trace#296
Merged
beaubelgrave merged 1 commit intoJun 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #289 (comment)
Changes
Adds an optional
--session-name <name>flag torecord-tracethat sets the ETW/perf session name used for recording. Defaults to"record-trace"when omitted, preserving current behavior.Motivation
record-tracepreviously hardcoded the session name"record-trace". On Windows, after the GUID-from-name fix (#289), the session name determines the session's identity:record-traceETW session per machine at a time, but a new run automatically reclaims a session left behind by a crashed one.record-traceETW sessions run side by side.On Linux the name has no such constraint. perf sessions are scoped per PID/CPU, so concurrent runs already work regardless of name. The flag is primarily a Windows concurrency control and reads as a harmless session label on Linux.
This flag lets users opt into concurrent recording on Windows when they need it, while keeping the safe singleton + crash-recovery default for the common case.