-
Notifications
You must be signed in to change notification settings - Fork 167
logview_new: allow comparing tests across all branches #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds support in the petri/logview_new UI to compare/analyze test performance across all branches, with a session-scoped user confirmation gate to avoid accidentally triggering a very heavy fetch/prefetch workflow. Also adds a quick “perf” navigation affordance from Run Details directly to the corresponding test’s performance view.
Changes:
- Add a session-wide verification context + prompt UI to gate “all branches” test analysis.
- Extend test analysis fetching to support
branchFilter === "all"(no branch filtering). - Add a “perf” link in Run Details test-name cells plus supporting CSS for hover behavior.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
petri/logview_new/src/verify_prompt.tsx |
New confirmation prompt shown before starting heavy “all branches” analysis. |
petri/logview_new/src/contexts/verify_get_all_context.tsx |
New React context/provider to persist the verification decision across pages for the session. |
petri/logview_new/src/tests.tsx |
Gate “all branches” fetch behind verification and show the prompt instead of the table until verified. |
petri/logview_new/src/test_details.tsx |
Same gating/prompt behavior for the per-test details view. |
petri/logview_new/src/fetch/fetch_runs_data.tsx |
Treat branchFilter === "all" as a special value meaning “don’t filter runs by branch”. |
petri/logview_new/src/table_defs/run_details.tsx |
Add “perf” link next to the test name to jump to the performance page for that test. |
petri/logview_new/src/styles/common.css |
Add CSS to position/animate the new “perf” link in Run Details rows. |
petri/logview_new/src/main.tsx |
Wrap app content with the new verification provider. |
petri/logview_new/src/branch_quick_filters.tsx |
Add "all" to the Tests/TestDetails quick filter list. |
petri/logview_new/biome.json |
Introduce Biome configuration for lint/format/organize-imports. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Allows comparing test performance across all branches. This is a heavy operation so this also adds a user check before launching lots of fetch commands. Also adds a little button on tests in the RunDetails view to directly jump to that tests perf (as opposed to searching it manually, just a minor convenience there)
User verify is global across a session so verifying under "Tests" also applies to "Test Details" page. it also correctly shows up on first load if someone were to point you directly to the all branch tests.
Sample: https://gurasinghms.github.io/openvmm/petri/logview_new/dist/#/tests?branchFilter=all