virtio_net: fix register read truncation at offset 16 #2776
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect bit shift when composing the virtio-net config register value returned at offset 16, ensuring rss_max_indirection_table_length is placed in the correct bit range and not truncated.
Changes:
- Shift
rss_max_indirection_table_lengthby 16 (bits[31:16]) instead of 24 duringread_registers_u32(16)composition.
The rss_max_indirection_table_length field was shifted left by 24 instead of 16, causing its upper bits to be truncated. This field occupies bits [23:16] of the register at offset 16, not bits [31:24].
benhillis
force-pushed
the
fix/virtio_net-register-shift
branch
from
9fe46d9 to
a09aba7
Compare
Brian-Perkins
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rss_max_indirection_table_length field was shifted left by 24 instead of 16, causing its upper bits to be truncated. This field occupies bits [23:16] of the register at offset 16, not bits [31:24].