-
Notifications
You must be signed in to change notification settings - Fork 167
flowey: vmm-tests must download alpine linux image #2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the local xflowey vmm-tests job so it downloads the Alpine Linux VHD artifacts needed by newly added Alpine-based VMM tests.
Changes:
- Add
KnownTestArtifacts::Alpine323X64Vhdto the downloaded artifact set when thelinuxtest selection flag is enabled (x86_64). - Add
KnownTestArtifacts::Alpine323Aarch64Vhdto the downloaded artifact set when thelinuxtest selection flag is enabled (aarch64).
| if linux { | ||
| artifacts.push(KnownTestArtifacts::Alpine323Aarch64Vhd); | ||
| } |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same selection-consistency issue as the x86_64 branch: Alpine aarch64 tests are named with alpine_3_23_aarch64 in the generated test names, so & !test(linux) won’t exclude them when linux is disabled. That can result in Alpine tests still running while this artifact isn’t downloaded.
Consider updating the filter (exclude test(alpine) when !linux) or adding a dedicated alpine flag used for both filtering and artifact downloads.
| if linux { | |
| artifacts.push(KnownTestArtifacts::Alpine323Aarch64Vhd); | |
| } | |
| artifacts.push(KnownTestArtifacts::Alpine323Aarch64Vhd); |
| if linux { | ||
| artifacts.push(KnownTestArtifacts::Alpine323X64Vhd); | ||
| } |
Copilot
AI
Feb 10, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linux selection flag currently only affects the nextest filter via & !test(linux) (and a few build toggles). Alpine-based tests generated by vmm_test_macros have names like *_uefi_*_alpine_3_23_* (they don’t contain the substring linux), so disabling linux won’t skip them. With this change, those Alpine artifacts also won’t be downloaded when linux is disabled, which can leave Alpine tests still selected but missing their required VHD.
To keep selections consistent, either (a) extend the filter logic so !linux also excludes Alpine tests (e.g., & !test(alpine) / & !test(alpine_3_23)), or (b) introduce an explicit alpine flag and use it for both filtering and artifact selection.
We now have tests that run against alpine. The
vmm-testsxflowey command wasn't downloading that image for the user. Add it.