Skip to content

Conversation

@mattkur
Copy link
Contributor

@mattkur mattkur commented Feb 10, 2026

We now have tests that run against alpine. The vmm-tests xflowey command wasn't downloading that image for the user. Add it.

@mattkur mattkur requested a review from a team as a code owner February 10, 2026 17:28
Copilot AI review requested due to automatic review settings February 10, 2026 17:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the local xflowey vmm-tests job so it downloads the Alpine Linux VHD artifacts needed by newly added Alpine-based VMM tests.

Changes:

  • Add KnownTestArtifacts::Alpine323X64Vhd to the downloaded artifact set when the linux test selection flag is enabled (x86_64).
  • Add KnownTestArtifacts::Alpine323Aarch64Vhd to the downloaded artifact set when the linux test selection flag is enabled (aarch64).

Comment on lines +396 to +398
if linux {
artifacts.push(KnownTestArtifacts::Alpine323Aarch64Vhd);
}
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same selection-consistency issue as the x86_64 branch: Alpine aarch64 tests are named with alpine_3_23_aarch64 in the generated test names, so & !test(linux) won’t exclude them when linux is disabled. That can result in Alpine tests still running while this artifact isn’t downloaded.

Consider updating the filter (exclude test(alpine) when !linux) or adding a dedicated alpine flag used for both filtering and artifact downloads.

Suggested change
if linux {
artifacts.push(KnownTestArtifacts::Alpine323Aarch64Vhd);
}
artifacts.push(KnownTestArtifacts::Alpine323Aarch64Vhd);

Copilot uses AI. Check for mistakes.
Comment on lines +378 to +380
if linux {
artifacts.push(KnownTestArtifacts::Alpine323X64Vhd);
}
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linux selection flag currently only affects the nextest filter via & !test(linux) (and a few build toggles). Alpine-based tests generated by vmm_test_macros have names like *_uefi_*_alpine_3_23_* (they don’t contain the substring linux), so disabling linux won’t skip them. With this change, those Alpine artifacts also won’t be downloaded when linux is disabled, which can leave Alpine tests still selected but missing their required VHD.

To keep selections consistent, either (a) extend the filter logic so !linux also excludes Alpine tests (e.g., & !test(alpine) / & !test(alpine_3_23)), or (b) introduce an explicit alpine flag and use it for both filtering and artifact selection.

Copilot uses AI. Check for mistakes.
@mattkur mattkur merged commit 77f392f into microsoft:main Feb 10, 2026
62 checks passed
@mattkur mattkur deleted the download-alpine branch February 10, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants