test_igvm_agent_rpc_server: migrate from winapi to windows-sys #2785
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the test_igvm_agent_rpc_server Windows FFI surface away from the legacy winapi crate to windows-sys, aligning with the repo-wide effort in #1061 to unify Windows API dependencies.
Changes:
- Replaced
winapi-sourced Win32 constants/types (e.g.,HRESULT,E_*) withwindows-sysequivalents. - Removed the
winapidependency fromtest_igvm_agent_rpc_server. - Updated
Cargo.lockaccordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vm/devices/get/test_igvm_agent_rpc_server/src/rpc/server.rs | Removes winapi BOOL import and replaces with a windows-sys BOOL import (currently from windows_sys::core). |
| vm/devices/get/test_igvm_agent_rpc_server/src/rpc/handlers.rs | Migrates HRESULT/E_* constants from winapi to windows-sys. |
| vm/devices/get/test_igvm_agent_rpc_server/Cargo.toml | Drops winapi dependency; relies on windows-sys features. |
| Cargo.lock | Removes winapi from this crate’s dependency list. |
justus-camp-microsoft
force-pushed
the
winapi_test_igvm_migration
branch
2 times, most recently
from
4ae85cb to
b3c13ad
Compare
justus-camp-microsoft
force-pushed
the
winapi_test_igvm_migration
branch
from
b3c13ad to
e35c91d
Compare
benhillis
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1061, removes winapi deps from test_igvm_agent_rpc_server