term: migrate from winapi to windows-sys #2786
Open
+17
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the support/term crate’s Windows console interaction from the legacy winapi crate to windows-sys, aligning with the repo’s effort in #1061 to consolidate Windows API dependencies.
Changes:
- Replaced
winapiWin32 console calls withwindows-sysequivalents inenable_vt_and_utf8(). - Updated
support/term’s Windows-only dependency fromwinapitowindows-syswith the required feature set. - Reflected the dependency swap in
Cargo.lock.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| support/term/src/lib.rs | Switches Win32 console API imports/calls from winapi to windows-sys. |
| support/term/Cargo.toml | Removes winapi dependency and adds windows-sys with Win32_Globalization and Win32_System_Console features. |
| Cargo.lock | Updates resolved deps for term from winapi to windows-sys. |
justus-camp-microsoft
force-pushed
the
term_winapi_migration
branch
from
9e310f4 to
5b88e24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1061, migrates support/term off of winapi