Skip to content

openvmm_entry: migrate from winapi to windows-sys #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justus-camp-microsoft merged 1 commit into from
Feb 26, 2026
Merged

openvmm_entry: migrate from winapi to windows-sys #2787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5303,7 +5303,7 @@ dependencies = [
"vtl2_settings_proto",
"whp",
"win_etw_tracing",
"winapi",
"windows-sys 0.61.0",
]

[[package]]
Expand Down
17 changes: 3 additions & 14 deletions openvmm/openvmm_entry/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,22 +113,11 @@ whp.workspace = true

win_etw_tracing.workspace = true

[target.'cfg(windows)'.dependencies.winapi]
[target.'cfg(windows)'.dependencies.windows-sys]
workspace = true
features = [
"consoleapi",
"handleapi",
"memoryapi",
"namedpipeapi",
"processenv",
"realtimeapiset",
"synchapi",
"winbase",
"wincon",
"winnls",
"winnt",
"winsock2",
Comment on lines -118 to -129
Copy link
Copy Markdown
Contributor Author

@justus-camp-microsoft justus-camp-microsoft Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, these were unneeded features besides the winnt feature.

Copy link
Copy Markdown
Contributor

@smalis-msft smalis-msft Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very possible, we don't have a solution for finding unused features today.

"Win32_Foundation",
]
workspace = true

[build-dependencies]
build_rs_guest_arch.workspace = true
Expand Down
3 changes: 2 additions & 1 deletion openvmm/openvmm_entry/src/serial_io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,8 @@ pub fn bind_serial(path: &Path) -> io::Result<Resource<SerialBackendHandle>> {
if path.starts_with("//./pipe") {
let pipe = pal::windows::pipe::new_named_pipe(
path,
winapi::um::winnt::GENERIC_READ | winapi::um::winnt::GENERIC_WRITE,
windows_sys::Win32::Foundation::GENERIC_READ
| windows_sys::Win32::Foundation::GENERIC_WRITE,
Comment on lines 240 to +243
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The access mask constants are referenced via long fully-qualified paths twice. Consider importing GENERIC_READ/GENERIC_WRITE (e.g., with a use inside this #[cfg(windows)] block) to reduce verbosity and make future refactors easier.

Copilot uses AI. Check for mistakes.
pal::windows::pipe::Disposition::Create,
pal::windows::pipe::PipeMode::Byte,
)?;
Expand Down