Skip to content

Conversation

@jaykrell
Copy link
Member

@jaykrell jaykrell commented Feb 10, 2026

This pull request adds a notification post-livemigration.
Guests are not generally meant to be aware of live migration, but there are or soon will be exceptions, and this will support them.

@jaykrell jaykrell requested a review from a team as a code owner February 10, 2026 23:38
Copilot AI review requested due to automatic review settings February 10, 2026 23:38
@jaykrell jaykrell marked this pull request as draft February 10, 2026 23:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for post-live-migration notifications in the Guest Emulation Transport (GET) protocol. It introduces a new guest notification type that will allow the host to notify the guest when a live migration has completed, enabling the guest to take appropriate actions in response.

Changes:

  • Adds NOTIFY_POST_LIVE_MIGRATION guest notification to the GET protocol
  • Implements callback infrastructure for handling post-live-migration notifications
  • Integrates the notification callback setup in OpenHCL worker initialization

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

File Description
vm/devices/get/get_protocol/src/lib.rs Defines new NOTIFY_POST_LIVE_MIGRATION guest notification constant
vm/devices/get/guest_emulation_transport/src/process_loop.rs Adds message type, field storage, and notification handling for post-live-migration callback
vm/devices/get/guest_emulation_transport/src/client.rs Adds public API method to set the post-live-migration notification callback
openhcl/underhill_core/src/worker.rs Attempts to wire up the callback in OpenHCL initialization

@jaykrell jaykrell force-pushed the dev/jaykrell/manticore-1 branch 5 times, most recently from 89cd82a to 8df0c14 Compare February 11, 2026 00:38
@jaykrell jaykrell force-pushed the dev/jaykrell/manticore-1 branch from 8df0c14 to 96f62f7 Compare February 11, 2026 00:40
@jaykrell jaykrell marked this pull request as ready for review February 11, 2026 00:53
@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant