ci: cleanup gh and ado pools#3394
Conversation
tjones60
changed the title
There was a problem hiding this comment.
Pull request overview
Refactors Flowey CI pool/image selection to centralize and standardize GitHub and ADO runner pool naming, and updates checkin gate pipelines to use the new helpers.
Changes:
- Centralizes GitHub pool/image constants and adds
default_*helpers ingh_pools.rs. - Refactors ADO pool selection similarly in
ado_pools.rs, reusing image constants. - Updates
checkin_gates.rsto use the new default pool helpers and simplifies ADO job skipping logic for VMM tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
flowey/flowey_hvlite/src/pipelines_shared/gh_pools.rs |
Introduces pool/image constants, shared helper constructor, and new “default” selection helpers. |
flowey/flowey_hvlite/src/pipelines_shared/ado_pools.rs |
Adds pool/image helpers for ADO and default selection logic (plus header change). |
flowey/flowey_hvlite/src/pipelines/checkin_gates.rs |
Switches job definitions to use the new pool defaults; refactors ADO skipping for VMM test jobs. |
tjones60
changed the title
tjones60
added
the
release-ci-required
smalis-msft
left a comment
smalis-msft
left a comment
There was a problem hiding this comment.
So this is moving a bunch of jobs onto our 1es runners instead of the github ones right? What's the reasoning for that, are they faster? Do we have enough capacity?
The only significant change is that this switches all clippy/unit test jobs to 1es runners. We already had to run around half of them running on 1es for various reasons, so it isn't actually that big of a change. Mostly I wanted to make things consistent, and yes, the 1es runners are several times faster, so you can see if clippy and unit tests pass sooner, even if it doesn't change overall ci time. I think we have a capacity for a couple for runners per job. |
|
I'll rebase #3388 on top of this PR after it merges and see if that gets us even better perf. |
Refactor and standardize naming of pools and images in flowey. Moves all ubuntu jobs to a clean, updated ubuntu image with nothing preinstalled and uses the 1es pools for all clippy/unit test jobs.