wip: new 1es pools#3412
Open
tjones60 wants to merge 6 commits intomicrosoft:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CI runner pool/image selection for 1ES-backed GitHub Actions/Azure DevOps pipelines, moving to the new pool names and “-v2” image overrides, and temporarily disabling the Linux MSHV vmm-tests job.
Changes:
- Switch 1ES pool names to
openvmm-gh-{amd,intel,arm}and update image override strings to*-v2. - Update generated PR pipeline YAMLs (GitHub + ADO) to demand the new image overrides.
- Disable the
x64-linux-intel-mshvvmm-tests job incheckin_gates(currently via commented-out params).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| flowey/flowey_hvlite/src/pipelines_shared/gh_pools.rs | Updates centralized 1ES pool/image constants to new pool names and -v2 images. |
| flowey/flowey_hvlite/src/pipelines/checkin_gates.rs | Disables the MSHV vmm-tests job and adjusts an unused artifact variable. |
| ci-flowey/openvmm-pr.yaml | Updates ADO pool image demands to ubuntu2404-amd64-v2 / win-amd64-v2. |
| .github/workflows/openvmm-pr.yaml | Updates GitHub runner labels to new pools/images and removes the MSHV vmm-tests job from the workflow. |
| .github/workflows/openvmm-pr-release.yaml | Same as above for the optional release PR workflow. |
Comments suppressed due to low confidence (1)
flowey/flowey_hvlite/src/pipelines/checkin_gates.rs:1190
vmm_tests_artifacts_linux_musl_x86.finish()is still being called and will error with "missing required linux-mshv (musl) vmm_tests artifact" even though the MSHV vmm-tests job is currently disabled below. This keeps an unnecessary hard requirement (and a misleading error message) in the pipeline; consider removing this.finish()call or gating it behind the same condition used to include the MSHV job.
let _vmm_tests_artifacts_linux_mshv_x86 = vmm_tests_artifacts_linux_musl_x86
.finish()
.map_err(|missing| {
anyhow::anyhow!("missing required linux-mshv (musl) vmm_tests artifact: {missing}")
})?;
Comment on lines
+259
to
+261
| if !temp_dir.exists() { | ||
| fs_err::create_dir_all(&temp_dir)? | ||
| }; |
Comment on lines
+1391
to
1406
| // VmmTestJobParams { | ||
| // platform: FlowPlatform::Linux(FlowPlatformLinuxDistro::AzureLinux), | ||
| // arch: FlowArch::X86_64, | ||
| // gh_pool: gh_pools::linux_mshv_1es(), | ||
| // ado_pool: None, | ||
| // temp_dir: temp_dir_from(gh_pools::WINDOWS_WORK_FOLDER), | ||
| // label: "x64-linux-intel-mshv", | ||
| // target: CommonTriple::X86_64_LINUX_MUSL, | ||
| // resolve_vmm_tests_artifacts: vmm_tests_artifacts_linux_mshv_x86, | ||
| // // - No legal way to obtain gen1 pcat blobs on non-msft linux machines | ||
| // nextest_filter_expr: format!("{standard_filter} & !test(pcat_x64)"), | ||
| // test_artifacts: standard_x64_test_artifacts.clone(), | ||
| // needs_prep_run: false, | ||
| // hugetlb_2mb_overcommit_pages: None, | ||
| // }, | ||
| VmmTestJobParams { |
| pub test_content_dir: ReadVar<PathBuf>, | ||
| /// Specify where VMM tests disk images are stored. | ||
| pub disk_images_dir: Option<ReadVar<PathBuf>>, | ||
| /// Specify where tempory files used by tests are stored. |
Comment on lines
+538
to
+542
| apic_mode: proc_topology.apic_mode.map(|m| match m { | ||
| ApicMode::Xapic => HyperVApicMode::Legacy, | ||
| ApicMode::X2apicSupported => HyperVApicMode::X2Apic, | ||
| ApicMode::X2apicEnabled => HyperVApicMode::X2Apic, | ||
| }), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use gen2 images and new skus for runners. Haven't gotten the mshv image working yet.