crypto: Cleanup RSA, add Symcrypt support#3423
Open
smalis-msft wants to merge 5 commits intomicrosoft:mainfrom
Open
crypto: Cleanup RSA, add Symcrypt support#3423smalis-msft wants to merge 5 commits intomicrosoft:mainfrom
smalis-msft wants to merge 5 commits intomicrosoft:mainfrom
Conversation
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a second backend implementation for RSA we can clean up the interface and make it nice. So this PR is a near complete rewrite of our openssl backend, an addition of the symcrypt backend, and the introduction of the RustCrypto parsing crates for use with symcrypt.
The transmutes are unfortunate, but they do allow for a much nicer interface, and they should be guaranteed safe.