cvm: Log vp index on memory failures#3425
Merged
smalis-msft merged 2 commits intomicrosoft:mainfrom May 6, 2026
Merged
Conversation
chris-oo
approved these changes
May 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves diagnosability of CVM memory-access failures by adding the current VP index as a structured field on the ratelimited warning emitted when the guest accesses an inaccessible GPA and a machine check (MC) is injected.
Changes:
- Add
vp = self.vp_index().index()to theguest accessed inaccessible gpa, injecting MCratelimited warning log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in teams, this may help with debugging