ci(e2e-docker): skip 54_reconcile_orphans in Docker harness#289
Merged
Conversation
The Docker E2E harness runs every test against a single fixed-config container. 54_reconcile_orphans (added in #283) needs the reconcile phase GUCs (reconcile_interval=2, retention_days=0) so a reconcile pass reclaims a fresh orphan within the test's 30s poll window. Under the container's production defaults (reconcile_interval=3600, retention_days=30) the BGW's reconcile timer, armed once at startup, never ticks in time, so the orphan is never reclaimed and the test fails. Add it to SKIP_TESTS alongside the other phase-dependent tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The nightly Docker E2E run has failed 2 days in a row at
54_reconcile_orphans:Root cause
scripts/test-e2e-docker.shruns every test against a single container with fixed, production-default configuration. Tests that need non-default startup GUCs are listed inSKIP_TESTS(superuser GUC, connection-limit, HTTP phases).54_reconcile_orphans(added in #283) needs thereconcilephase GUCs —pg_durable.reconcile_interval = 2andpg_durable.retention_days = 0— which the local harness applies by rewritingpostgresql.confand restarting per phase. In the Docker container those GUCs stay at production defaults (reconcile_interval = 3600,retention_days = 30):The GUCs can't be applied at runtime either (the reconcile cadence is computed once before the worker loop). PR CI passes because
ci.ymluses the local harness that honors phases; only the nightly Docker run exercises this path.PR #283 introduced a phase-specific test but didn't add it to the Docker skip list — matching when the nightly began failing.
Fix
Add
54_reconcile_orphanstoSKIP_TESTSinscripts/test-e2e-docker.sh, consistent with the other phase-dependent tests.