fix(screencast): correct overlay/chapter channels#3303
Merged
dgozman merged 1 commit intoMay 1, 2026
Conversation
Map overlay/chapter/visibility calls to screencastShowOverlay, screencastRemoveOverlay, screencastChapter, and screencastSetOverlayVisible. Adds tests that confirm the bug and the fix. Fixes microsoft#3302
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
Author
|
Happy to help! In fact, I'm eager to use the screencast features on lots of our projects and have already prepared a significant refactoring across multiple of our testing projects to generate artifacts... but I can't go through with it until the fix is published. I'm aware of multiple workarounds to getting non-officially-published versions into our project's dependencies, but I would very much prefer not have to deal with all the nasty consequences of those approaches. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
screencast*channel methods expected by the driver.Fixes #3302