Skip to content

Improve symlink directory detection in environment finder#328

Merged
karthiknadig merged 4 commits intomainfrom
fix-symlink-directory-detection
Feb 5, 2026
Merged

Improve symlink directory detection in environment finder#328
karthiknadig merged 4 commits intomainfrom
fix-symlink-directory-detection

Conversation

@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Feb 4, 2026

Fixes #196

Enhance the detection of symlinked directories in the environment finder by using path().is_dir() instead of file_type().is_dir(). This change addresses an issue where symlinked virtual environments were not recognized on Unix systems. Additional tests ensure that both symlinked and regular directories are correctly detected.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Performance Report (Linux) 🚀

Metric PR Baseline Delta Change
Server Startup 1ms 1ms 0ms 0%
Full Refresh 454ms 589ms -135ms -20.0%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 57.2%
Base Branch Coverage 56.7%
Delta .5% ✅

Coverage increased! Great work!

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Performance Report (Windows) 🚀

Metric PR Baseline Delta Change
Server Startup 16ms 15ms 1ms 6.7%
Full Refresh 2744ms 11143ms -8399ms -75.4%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 52.94%
Base Branch Coverage 52.77%
Delta 0.17% ✅

Coverage increased! Great work!

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (macOS)

Metric PR Baseline Delta
Server Startup 1007ms 905ms 102ms
Full Refresh 59795ms 49485ms 10310ms

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig marked this pull request as ready for review February 5, 2026 06:02
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 5, 2026
@karthiknadig karthiknadig enabled auto-merge (squash) February 5, 2026 06:06
@karthiknadig karthiknadig merged commit 9e0ef7a into main Feb 5, 2026
30 checks passed
@karthiknadig karthiknadig deleted the fix-symlink-directory-detection branch February 5, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug/regression: symlink not properly resolved for python virtual environments

2 participants