Improve symlink directory detection in environment finder#328
Merged
karthiknadig merged 4 commits intomainfrom Feb 5, 2026
Merged
Improve symlink directory detection in environment finder#328karthiknadig merged 4 commits intomainfrom
karthiknadig merged 4 commits intomainfrom
Conversation
Performance Report (Linux) 🚀
Legend
|
Test Coverage Report (Linux)
Coverage increased! Great work! |
Performance Report (Windows) 🚀
Legend
|
Test Coverage Report (Windows)
Coverage increased! Great work! |
Performance Report (macOS)
Legend
|
connor4312
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196
Enhance the detection of symlinked directories in the environment finder by using
path().is_dir()instead offile_type().is_dir(). This change addresses an issue where symlinked virtual environments were not recognized on Unix systems. Additional tests ensure that both symlinked and regular directories are correctly detected.