Skip to content

Add WinPython support and testing#330

Merged
karthiknadig merged 3 commits intomainfrom
rising-crocodile
Feb 5, 2026
Merged

Add WinPython support and testing#330
karthiknadig merged 3 commits intomainfrom
rising-crocodile

Conversation

@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Feb 5, 2026

Fixes #96

Introduce support for detecting WinPython environments.

Changes

  • Add new \pet-winpython\ crate for WinPython environment detection
  • Add \WinPython\ to \PythonEnvironmentKind\ and \LocatorKind\ enums
  • Integrate WinPython locator into the locator chain
  • Update JSONRPC documentation

Detection Strategy

WinPython environments are identified by:

  1. Marker files: .winpython\ or \winpython.ini\ in parent directories
  2. Directory naming pattern: \WPy64-, \WPy32-, or \WPy-*\
  3. Python folder naming: \python-X.Y.Z.amd64\ or \python-X.Y.Z\

Testing

Added 14 tests covering directory/folder name patterns, version extraction, marker file detection, and locator trait verification.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (Linux) 🚀

Metric PR Baseline Delta Change
Server Startup 1ms 1ms 0ms 0%
Full Refresh 470ms 589ms -119ms -20.0%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 56.8%
Base Branch Coverage 56.7%
Delta .1% ✅

Coverage increased! Great work!

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 53.68%
Base Branch Coverage 52.77%
Delta 0.91% ✅

Coverage increased! Great work!

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (Windows) 🚀

Metric PR Baseline Delta Change
Server Startup 15ms 15ms 0ms 0%
Full Refresh 2939ms 11143ms -8204ms -73.6%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (macOS)

Metric PR Baseline Delta
Server Startup 1231ms 905ms 326ms
Full Refresh 64158ms 49485ms 14673ms

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig marked this pull request as ready for review February 5, 2026 15:04
@karthiknadig karthiknadig enabled auto-merge (squash) February 5, 2026 15:05
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 5, 2026
@karthiknadig karthiknadig merged commit d9fc8f7 into main Feb 5, 2026
46 of 47 checks passed
@karthiknadig karthiknadig deleted the rising-crocodile branch February 5, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for WinPython environments

2 participants