Improve conda environment name retrieval logic for external environments#331
Merged
karthiknadig merged 7 commits intomainfrom Feb 5, 2026
Merged
Improve conda environment name retrieval logic for external environments#331karthiknadig merged 7 commits intomainfrom
karthiknadig merged 7 commits intomainfrom
Conversation
Test Coverage Report (Linux)
Coverage increased! Great work! |
Performance Report (Linux)
|
| Metric | PR | Baseline | Delta | Change |
|---|---|---|---|---|
| Server Startup | 1ms | 1ms | 0ms | 0% |
| Full Refresh | 1025ms | 520ms | 505ms | 90.0% |
Legend
- 🚀 Significant speedup (>100ms faster)
- ✅ Faster than baseline
- ➖ No significant change
- 🔺 Slower than baseline (>100ms)
⚠️ Significant slowdown (>500ms)
Test Coverage Report (Windows)
Coverage increased! Great work! |
Performance Report (Windows)
|
| Metric | PR | Baseline | Delta | Change |
|---|---|---|---|---|
| Server Startup | 14ms | 15ms | -1ms | -6.7% |
| Full Refresh | 2600ms | 2079ms | 521ms | 25.1% |
Legend
- 🚀 Significant speedup (>100ms faster)
- ✅ Faster than baseline
- ➖ No significant change
- 🔺 Slower than baseline (>100ms)
⚠️ Significant slowdown (>500ms)
…d name-based environments
…rnal environments
…s to ensure safe activation
Performance Report (macOS)
Legend
|
…onments to ensure accurate activation
dmitrivMS
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
Enhance the logic for retrieving conda environment names to correctly handle external environments and ensure proper activation. This change checks the history file when the conda directory is unknown or when the prefix does not match the conda directory.