Skip to content

refactor: update PyVenvCfg to use Option types for version fields and adjust related logic#333

Merged
karthiknadig merged 1 commit intomainfrom
mid-kite
Feb 5, 2026
Merged

refactor: update PyVenvCfg to use Option types for version fields and adjust related logic#333
karthiknadig merged 1 commit intomainfrom
mid-kite

Conversation

@karthiknadig
Copy link
Member

Fixes #332

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 56.7%
Base Branch Coverage 56.7%
Delta 0% ➖

Coverage unchanged.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (Linux) 🔺

Metric PR Baseline Delta Change
Server Startup 1ms 1ms 0ms 0%
Full Refresh 492ms 187ms 305ms 160.0%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (Windows) ⚠️

Metric PR Baseline Delta Change
Server Startup 13ms 15ms -2ms -13.3%
Full Refresh 17348ms 742ms 16606ms 2238%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 52.78%
Base Branch Coverage 52.77%
Delta 0.01% ✅

Coverage increased! Great work!

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (macOS)

Metric PR Baseline Delta
Server Startup 867ms 905ms -38ms
Full Refresh 49882ms 49485ms 397ms

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig marked this pull request as ready for review February 5, 2026 15:02
@karthiknadig karthiknadig enabled auto-merge (squash) February 5, 2026 15:02
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 5, 2026
@karthiknadig karthiknadig merged commit 9d42321 into main Feb 5, 2026
30 checks passed
@karthiknadig karthiknadig deleted the mid-kite branch February 5, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyvenv.cfg parsing fails silently when version field is missing

2 participants