Skip to content

Update preference order for local venv in poetry environment #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karthiknadig merged 1 commit into from
Feb 5, 2026
+9 −9
Merged

Update preference order for local venv in poetry environment #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions crates/pet-poetry/src/environment_locations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ fn list_all_environments_from_project_config(

// Check if we're allowed to use .venv as a poetry env
// This can be configured in global, project or env variable.
// Order of preference is Global, EnvVariable & Project (project wins)
// Order of preference is Project (local config) > EnvVariable > Global
if should_use_local_venv_as_poetry_env(global, &local, env) {
// If virtualenvs are in the project, then look for .venv
let venv = path.join(".venv");
Expand All @@ -121,21 +121,21 @@ fn should_use_local_venv_as_poetry_env(
local: &Option<Config>,
env: &EnvVariables,
) -> bool {
// Given preference to env variable.
if let Some(poetry_virtualenvs_in_project) = env.poetry_virtualenvs_in_project {
// Give preference to setting in local config file (project-level).
if let Some(poetry_virtualenvs_in_project) =
local.clone().and_then(|c| c.virtualenvs_in_project)
{
trace!(
"Poetry virtualenvs_in_project from Env Variable: {}",
"Poetry virtualenvs_in_project from local config file: {}",
poetry_virtualenvs_in_project
);
return poetry_virtualenvs_in_project;
}

// Give preference to setting in local config file.
if let Some(poetry_virtualenvs_in_project) =
local.clone().and_then(|c| c.virtualenvs_in_project)
{
// Then check env variable.
if let Some(poetry_virtualenvs_in_project) = env.poetry_virtualenvs_in_project {
trace!(
"Poetry virtualenvs_in_project from local config file: {}",
"Poetry virtualenvs_in_project from Env Variable: {}",
poetry_virtualenvs_in_project
);
return poetry_virtualenvs_in_project;
Expand Down
Loading