fix: update tracing subscriber to write JSON output to stderr#340
Merged
eleanorjboyd merged 1 commit intomainfrom Feb 5, 2026
Merged
fix: update tracing subscriber to write JSON output to stderr#340eleanorjboyd merged 1 commit intomainfrom
eleanorjboyd merged 1 commit intomainfrom
Conversation
Test Coverage Report (Linux)
Coverage unchanged. |
Performance Report (Linux) 🚀
Legend
|
Performance Report (Windows)
|
| Metric | PR | Baseline | Delta | Change |
|---|---|---|---|---|
| Server Startup | 17ms | 15ms | 2ms | 13.3% |
| Full Refresh | 2975ms | 2079ms | 896ms | 43.1% |
Legend
- 🚀 Significant speedup (>100ms faster)
- ✅ Faster than baseline
- ➖ No significant change
- 🔺 Slower than baseline (>100ms)
⚠️ Significant slowdown (>500ms)
Test Coverage Report (Windows)
Coverage unchanged. |
karthiknadig
approved these changes
Feb 5, 2026
Performance Report (macOS)
Legend
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke: The commit added performance tracing/logging code. The new code was using a library called tracing-subscriber which, by default, writes log messages to stdout. This corrupted the JSONRPC protocol, causing the "Connection Error" and endless loading.
Fix: tracing library to write to stderr (standard error) instead of stdout.
resolves: #341