Skip to content

fix: update tracing subscriber to write JSON output to stderr#340

Merged
eleanorjboyd merged 1 commit intomainfrom
prior-raccoon
Feb 5, 2026
Merged

fix: update tracing subscriber to write JSON output to stderr#340
eleanorjboyd merged 1 commit intomainfrom
prior-raccoon

Conversation

@eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Feb 5, 2026

What broke: The commit added performance tracing/logging code. The new code was using a library called tracing-subscriber which, by default, writes log messages to stdout. This corrupted the JSONRPC protocol, causing the "Connection Error" and endless loading.

Fix: tracing library to write to stderr (standard error) instead of stdout.

resolves: #341

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 57.6%
Base Branch Coverage 57.6%
Delta 0% ➖

Coverage unchanged.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (Linux) 🚀

Metric PR Baseline Delta Change
Server Startup 1ms 1ms 0ms 0%
Full Refresh 364ms 520ms -156ms -30.0%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (Windows) ⚠️

Metric PR Baseline Delta Change
Server Startup 17ms 15ms 2ms 13.3%
Full Refresh 2975ms 2079ms 896ms 43.1%

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 54.15%
Base Branch Coverage 54.15%
Delta 0% ➖

Coverage unchanged.

@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 5, 2026
@eleanorjboyd eleanorjboyd enabled auto-merge (squash) February 5, 2026 18:24
@eleanorjboyd eleanorjboyd merged commit 7c7340a into main Feb 5, 2026
29 of 30 checks passed
@eleanorjboyd eleanorjboyd deleted the prior-raccoon branch February 5, 2026 18:28
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Report (macOS)

Metric PR Baseline Delta
Server Startup 869ms 1239ms -370ms
Full Refresh 48466ms 71109ms -22643ms

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSONRPC Server Connection Failure Due to Stdout Contamination

2 participants