Exercise description for "Prepare Arbitrary State" incorrectly constrains α as non-negative#3194
Open
minestarks wants to merge 1 commit intomainfrom
Open
Exercise description for "Prepare Arbitrary State" incorrectly constrains α as non-negative#3194minestarks wants to merge 1 commit intomainfrom
minestarks wants to merge 1 commit intomainfrom
Conversation
…ains α as non-negative
swernli
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Single-Qubit Gates kata, the "Prepare Arbitrary State" exercise description states:
However, the verification test generates test cases with negative α values (e.g.,
alpha = Cos(2) ≈ -0.416), and the reference solution usesArcTan2(beta, alpha)which handles negative α correctly.Why the "non-negative" constraint is wrong
The pedagogical goal of this exercise is to teach students to use
ArcTan2(beta, alpha)rather than the simplerArcSin(beta). If α were truly non-negative, a student could ignore thealphaparameter entirely and write:This would trivially pass, defeating the purpose of the exercise. The exercise hint even explicitly mentions
ArcTan2, confirming the intended solution requires both inputs.