Skip to content

Fix a crash calling CallInvoker during shutdown #16310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoates-ms merged 3 commits into from
Jul 14, 2026
+21 −8
Merged

Fix a crash calling CallInvoker during shutdown #16310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9d16dc
Fix a crash calling CallInvoker during shutdown
acoates-ms Jul 14, 2026
748e6cb
Change files
acoates-ms Jul 14, 2026
09a31f8
build fix
acoates-ms Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-4672fa37-ea7f-4ffd-82cd-40e7d8b41de5.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Fix a crash calling CallInvoker during shutdown",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
22 changes: 14 additions & 8 deletions vnext/Microsoft.ReactNative.Cxx/TurboModuleProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,23 @@ struct AbiCallInvoker final : facebook::react::CallInvoker {
AbiCallInvoker(IReactContext const &context) : m_context(context) {}

void invokeAsync(facebook::react::CallFunc &&func) noexcept override {
m_context.CallInvoker().InvokeAsync(
[context = m_context, func = std::move(func)](const winrt::Windows::Foundation::IInspectable &runtimeHandle) {
func(GetOrCreateContextRuntime(context, runtimeHandle));
});
auto callInvoker = m_context.CallInvoker();
if (callInvoker) {
callInvoker.InvokeAsync(
[context = m_context, func = std::move(func)](const winrt::Windows::Foundation::IInspectable &runtimeHandle) {
func(GetOrCreateContextRuntime(context, runtimeHandle));
});
}
}

void invokeSync(facebook::react::CallFunc &&func) override {
m_context.CallInvoker().InvokeSync(
[context = m_context, func = std::move(func)](const winrt::Windows::Foundation::IInspectable &runtimeHandle) {
func(GetOrCreateContextRuntime(context, runtimeHandle));
});
auto callInvoker = m_context.CallInvoker();
if (callInvoker) {
callInvoker.InvokeSync(
[context = m_context, func = std::move(func)](const winrt::Windows::Foundation::IInspectable &runtimeHandle) {
func(GetOrCreateContextRuntime(context, runtimeHandle));
});
}
}

private:
Expand Down
Loading