[npm-check-fork] - Replace package-json and throat dependencies by TheLarkInn · Pull Request #5565 · microsoft/rushstack

TheLarkInn · 2026-01-24T17:30:44Z

Summary

Removes external dependencies package-json (ESM-only, ~500KB dependency tree) and throat (redundant concurrency limiter) from @rushstack/npm-check-fork.

Replaced with:

NpmRegistryClient - minimal registry client using Node.js built-in https module
- Next step here would be to extract WebClient from rush-lib into its own package and then use here.
Promise.all batch processing for concurrent requests

Details

New files:

src/NpmRegistryClient.ts - registry client with fetchPackageMetadataAsync
src/tests/NpmRegistryClient.test.ts

Modified files:

src/GetLatestFromRegistry.ts - uses NpmRegistryClient instead of package-json
src/interfaces/INpmCheckRegistry.ts - added registry response types
src/index.ts - exports new client and getNpmInfoBatch function

Internal refactoring only.

How it was tested

rush build --to @rushstack/npm-check-fork - passes
rush test --only @rushstack/npm-check-fork - passes
Ready for manual verification with rush upgrade-interactive

Impacted documentation

None - internal implementation change only.

Copilot

Pull request overview

Removes the external package-json and throat dependencies from @rushstack/npm-check-fork by introducing a lightweight npm registry client and updating registry lookup logic accordingly.

Changes:

Added NpmRegistryClient implemented with Node.js http/https (plus a basic test file).
Refactored GetLatestFromRegistry to use NpmRegistryClient and introduced getNpmInfoBatch with configurable concurrency.
Updated types/exports and removed the external dependencies from package.json and lockfiles.

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
libraries/npm-check-fork/src/NpmRegistryClient.ts	New minimal registry client implemented via Node `http/https`.
libraries/npm-check-fork/src/GetLatestFromRegistry.ts	Swaps registry fetch to `NpmRegistryClient` and adds batched lookup helper.
libraries/npm-check-fork/src/interfaces/INpmCheckRegistry.ts	Adds registry response types used by the new client/refactor.
libraries/npm-check-fork/src/index.ts	Exports the new client/types and `getNpmInfoBatch`.
libraries/npm-check-fork/src/tests/GetLatestFromRegistry.test.ts	Updates tests to mock `NpmRegistryClient` instead of `package-json`.
libraries/npm-check-fork/src/tests/NpmRegistryClient.test.ts	Adds initial (currently minimal) test scaffolding for the new client.
libraries/npm-check-fork/package.json	Removes `package-json`/`throat`, adds `@rushstack/node-core-library`.
libraries/npm-check-fork/CHANGELOG.md	Adds a new version entry describing the dependency replacement.
common/changes/@rushstack/npm-check-fork/atomic-style-claude_2026-01-24-18-36.json	Changeset for the patch release.
common/config/subspaces/**/pnpm-lock.yaml, repo-state.json	Lockfile/hash updates reflecting dependency changes.

Files not reviewed (2)

common/config/subspaces/build-tests-subspace/pnpm-lock.yaml: Language not supported
common/config/subspaces/default/pnpm-lock.yaml: Language not supported

Copilot · 2026-01-24T20:09:31Z

@TheLarkInn I've opened a new pull request, #5566, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-24T23:54:37Z

@TheLarkInn I've opened a new pull request, #5567, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-24T23:56:26Z

@TheLarkInn I've opened a new pull request, #5568, to work on those changes. Once the pull request is ready, I'll request review from you.

Add INpmRegistryPackageResponse and INpmRegistryVersionMetadata interfaces to support the upcoming replacement of the package-json dependency with a local implementation using WebClient. - INpmRegistryVersionMetadata extends INpmCheckPackageVersion for backward compatibility - INpmRegistryPackageResponse models the full npm registry API response - Added JSDoc with links to npm registry API documentation

…data Implement NpmRegistryClient class to replace external package-json dependency with a self-contained HTTP client using Node.js built-in modules. Features: - INpmRegistryClientOptions for configuring registry URL, user agent, timeout - INpmRegistryClientResult for consistent error handling - Automatic scoped package URL encoding (@scope/name -> @scope%2Fname) - Support for gzip/deflate response decompression - Proper error handling for 404, HTTP errors, network errors, and timeouts

Replace package-json and throat dependencies with NpmRegistryClient for fetching npm registry metadata. Preserves existing version sorting and homepage extraction logic. Changes: - Remove package-json and throat imports - Add lazy-initialized module-level NpmRegistryClient instance - Update getNpmInfo to use fetchPackageMetadataAsync - Preserve lodash/semver version sorting - Preserve bestGuessHomepage extraction

…hing Add batch fetching function to retrieve metadata for multiple packages concurrently with configurable concurrency limit. Features: - getNpmInfoBatch(packageNames, concurrency) returns Map<string, INpmRegistryInfo> - Default concurrency matches CPU count (like original throat behavior) - Processes packages in batches using Promise.all

Remove external dependencies that have been replaced by NpmRegistryClient: - package-json: replaced by NpmRegistryClient - throat: replaced by Promise.all batch processing Update tests to mock NpmRegistryClient instead of package-json.

Add basic unit tests for NpmRegistryClient constructor options. Update GetLatestFromRegistry tests with improved module mocking.

Document the removal of package-json and throat dependencies in favor of internal NpmRegistryClient implementation.

…esn't (#5567) * Initial plan * docs: reword JSDoc for structural compatibility instead of extends Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>

…5568) * Initial plan * test(npm-check-fork): add comprehensive unit tests for NpmRegistryClient with http mocking Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TheLarkInn <3408176+TheLarkInn@users.noreply.github.com>

github-project-automation Bot added this to Bug Triage Jan 24, 2026

github-project-automation Bot moved this to Needs triage in Bug Triage Jan 24, 2026

TheLarkInn commented Jan 24, 2026

View reviewed changes

Comment thread libraries/npm-check-fork/src/GetLatestFromRegistry.ts

TheLarkInn commented Jan 24, 2026

View reviewed changes

Comment thread libraries/npm-check-fork/src/NpmRegistryClient.ts

TheLarkInn marked this pull request as ready for review January 24, 2026 18:35

TheLarkInn requested review from D4N14L, apostolisms, dmichon-msft, iclanton, octogonz and patmill as code owners January 24, 2026 18:35

TheLarkInn requested review from Copilot and removed request for D4N14L, apostolisms, dmichon-msft, iclanton, octogonz and patmill January 24, 2026 19:12

Copilot started reviewing on behalf of TheLarkInn January 24, 2026 19:12 View session

Copilot AI reviewed Jan 24, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 24, 2026

fix(npm-check-fork): include package version in default User-Agent #5566

Closed

This was referenced Jan 24, 2026

[npm-check-fork] Fix API docs claiming interface extends when it doesn't #5567

Merged

[npm-check-fork] Add comprehensive unit tests for NpmRegistryClient with http mocking #5568

Merged

TheLarkInn mentioned this pull request Jan 25, 2026

[npm-check-fork] Perf optimization for fetchPackageMetadataAsync #5571

Open

TheLarkInn requested review from iclanton and octogonz January 25, 2026 02:30

iclanton moved this from Needs triage to In Progress in Bug Triage Jan 26, 2026

TheLarkInn and others added 14 commits January 27, 2026 10:28

test(npm-check-fork): add unit tests for NpmRegistryClient

3b73c38

Add basic unit tests for NpmRegistryClient constructor options. Update GetLatestFromRegistry tests with improved module mocking.

docs(npm-check-fork): update CHANGELOG for dependency replacement

a28a131

Document the removal of package-json and throat dependencies in favor of internal NpmRegistryClient implementation.

cleanup from code review

8d40f92

remove ai outputs

d216e0d

rush change

3e4f852

restore CHANGELOG.md

a948130

DROP: rush update

a4fa3bf

TheLarkInn force-pushed the atomic-style-claude branch from adb9f3c to a4fa3bf Compare January 27, 2026 18:33

TheLarkInn enabled auto-merge (squash) January 27, 2026 18:33

Hashah1 approved these changes Jan 27, 2026

View reviewed changes

TheLarkInn merged commit 8a813fb into main Jan 27, 2026
9 checks passed

TheLarkInn deleted the atomic-style-claude branch January 27, 2026 18:55

github-project-automation Bot moved this from In Progress to Closed in Bug Triage Jan 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[npm-check-fork] - Replace package-json and throat dependencies #5565

[npm-check-fork] - Replace package-json and throat dependencies #5565
TheLarkInn merged 14 commits into
mainfrom
atomic-style-claude

TheLarkInn commented Jan 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 24, 2026

Uh oh!

Copilot AI commented Jan 24, 2026

Uh oh!

Copilot AI commented Jan 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

TheLarkInn commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

How it was tested

Impacted documentation

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 24, 2026

Uh oh!

Copilot AI commented Jan 24, 2026

Uh oh!

Copilot AI commented Jan 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TheLarkInn commented Jan 24, 2026 •

edited

Loading