[ts-command-line] Remove abstract modifier from CommandLineParser and eliminate redundant _actions field#5587
Merged
dmichon-msft merged 4 commits intoFeb 4, 2026
Conversation
…_actions array Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove abstract modifier from CommandLineParser class
Remove abstract modifier from CommandLineParser and eliminate redundant _actions field
Feb 3, 2026
dmichon-msft
approved these changes
Feb 4, 2026
iclanton
approved these changes
Feb 4, 2026
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommandLineParser can now be instantiated directly without subclassing, useful for testing and simple CLI scenarios. The redundant
_actionsarray field has been removed in favor of deriving the list from_actionsByName.values().Changes
abstractmodifier fromCommandLineParserclass - no abstract methods exist, direct instantiation is safe_actionsarray field - redundant storage for action listactionsgetter now returnsArray.from(this._actionsByName.values())_actionsByName.values()directlyExample
Backward compatible - existing subclasses continue to work unchanged.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.