Skip to content

[playwright vscode extension] Normalize temporary directory path handling for remote environments #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheLarkInn merged 2 commits into from
Feb 3, 2026
Merged

[playwright vscode extension] Normalize temporary directory path handling for remote environments #5588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d96c39
fix: normalize temporary directory path handling for remote environments
TheLarkInn Feb 3, 2026
0d41d68
fix: use the more accurate logic
TheLarkInn Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions vscode-extensions/playwright-local-browser-server-vscode-extension/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,27 @@ const VSCODE_SETTINGS_EXTENSION_FILTER: string = `@ext:${EXTENSION_ID}`;
async function writeExtensionInstalledFileAsync(terminal: ITerminal): Promise<void> {
try {
// If on a remote environment, write a file to os.tempdir() using workspace fs
let tempDir: string;

let fileUri: vscode.Uri;
let tempDir: string;

if (vscode.env.remoteName) {
tempDir = await runWorkspaceCommandAsync({
const markerPrefix: string = '<<<TEMPDIR_START>>>';
const markerSuffix: string = '<<<TEMPDIR_END>>>';
const output: string = await runWorkspaceCommandAsync({
terminalOptions: { name: 'playwright-local-browser-server', hideFromUser: true },
commandLine: `node -p "require('node:os').tmpdir()"`,
commandLine: `node -p "'${markerPrefix}' + require('node:os').tmpdir() + '${markerSuffix}'"`,
terminal
});

const startIndex: number = output.indexOf(markerPrefix);
const endIndex: number = output.indexOf(markerSuffix);
Comment thread
TheLarkInn marked this conversation as resolved.
if (startIndex !== -1 && endIndex !== -1 && endIndex > startIndex) {
tempDir = output.substring(startIndex + markerPrefix.length, endIndex).trim();
} else {
throw new Error('Failed to parse temp directory from command output');
}

// For remote environments, use the vscode-remote scheme
// The workspace folder should have the correct scheme already
const workspaceFolder: vscode.WorkspaceFolder | undefined = vscode.workspace.workspaceFolders?.[0];
Expand Down
Loading