Skip to content

[rush] Fix .npmrc syncing cache bug that strips pnpm hoisting properties #5642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iclanton merged 1 commit into from
Feb 20, 2026
Merged

[rush] Fix .npmrc syncing cache bug that strips pnpm hoisting properties #5642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush-lib/fix-npmrc-syncing_2026-02-19-02-14.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix .npmrc syncing to common/temp incorrectly caching results, which caused pnpm-specific properties like hoist-pattern to be stripped when the same .npmrc was processed with different options.",
"type": "none"
}
],
"packageName": "@microsoft/rush"
}
10 changes: 0 additions & 10 deletions libraries/rush-lib/src/utilities/npmrcUtilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ export interface ILogger {
* The text of the the .npmrc.
*/

// create a global _combinedNpmrc for cache purpose
const _combinedNpmrcMap: Map<string, string> = new Map();

function _trimNpmrcFile(
options: Pick<
INpmrcTrimOptions,
Expand All @@ -41,10 +38,6 @@ function _trimNpmrcFile(
filterNpmIncompatibleProperties,
env = process.env
} = options;
const combinedNpmrcFromCache: string | undefined = _combinedNpmrcMap.get(sourceNpmrcPath);
if (combinedNpmrcFromCache !== undefined) {
return combinedNpmrcFromCache;
}

let npmrcFileLines: string[] = [];
if (linesToPrepend) {
Expand All @@ -70,9 +63,6 @@ function _trimNpmrcFile(

const combinedNpmrc: string = resultLines.join('\n');

//save the cache
_combinedNpmrcMap.set(sourceNpmrcPath, combinedNpmrc);

return combinedNpmrc;
}

Expand Down