fix: conditionally assign logFilePaths only when value is not undefined#5708
Merged
Merged
Conversation
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/32548397-4715-49df-ac93-946ff98db320
Copilot created this pull request from a session on behalf of
dmichon-msft
March 20, 2026 22:35
View session
dmichon-msft
approved these changes
Mar 20, 2026
bmiddha
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OperationExecutionRecordunconditionally overwrotethis.logFilePathswithundefinedwhencreateLogFileisfalse, discarding any previously set value (e.g. from cache restoration inCacheableOperationPlugin).Changes
OperationExecutionRecord.ts: Guard the assignment sothis.logFilePathsis only updated whenlogFilePaths !== undefined:@microsoft/rush.