Skip to content

fix: conditionally assign logFilePaths only when value is not undefined#5708

Merged
dmichon-msft merged 1 commit into
mainfrom
copilot/patch-set-logfilepaths-conditionally
Mar 20, 2026
Merged

fix: conditionally assign logFilePaths only when value is not undefined#5708
dmichon-msft merged 1 commit into
mainfrom
copilot/patch-set-logfilepaths-conditionally

Conversation

Copilot AI commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

OperationExecutionRecord unconditionally overwrote this.logFilePaths with undefined when createLogFile is false, discarding any previously set value (e.g. from cache restoration in CacheableOperationPlugin).

Changes

  • OperationExecutionRecord.ts: Guard the assignment so this.logFilePaths is only updated when logFilePaths !== undefined:
// Before
this.logFilePaths = logFilePaths; // always set, even when undefined

// After
if (logFilePaths !== undefined) {
  this.logFilePaths = logFilePaths;
}
  • Change file: Patch bump for @microsoft/rush.

@dmichon-msft dmichon-msft marked this pull request as ready for review March 20, 2026 22:35
@dmichon-msft dmichon-msft merged commit 9cf810a into main Mar 20, 2026
9 checks passed
@dmichon-msft dmichon-msft deleted the copilot/patch-set-logfilepaths-conditionally branch March 20, 2026 22:58
@github-project-automation github-project-automation Bot moved this from Needs triage to Closed in Bug Triage Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants