Skip to content

Add dlopen command.#774

Open
michaelcfanning wants to merge 2 commits into
mainfrom
dlopen
Open

Add dlopen command.#774
michaelcfanning wants to merge 2 commits into
mainfrom
dlopen

Conversation

@michaelcfanning

Copy link
Copy Markdown
Member

@shaopeng-gh

Copy link
Copy Markdown
Contributor

Not familiar with these, looks good, will try it.

@shaopeng-gh shaopeng-gh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread Src/RE2.Managed/NativeMethods.cs Outdated
if (isLinux) { LoadLibrary(filePath); } else { LinuxMethods.dlopen(filePath, LinuxMethods.RTLD_NOW); }
}
}
else if (platform == "win")

@yongyan-gh yongyan-gh Jun 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(platform == "win")

nit: when platform == "win". isLinux should always be false. not needed to check isLinux in below if condition? #Resolved

@yongyan-gh yongyan-gh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yongyan-gh

Copy link
Copy Markdown
Contributor

looks like a P/Invoke the dlopen method from native dynamic library in linux platform.


In reply to: 1603348892

@shaopeng-gh

Copy link
Copy Markdown
Contributor

@michaelcfanning I think you have made it for the other direction for IronRe2, looks like we can close this PR,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants