Draft
Conversation
Introduce agentic identity support in ConversationClientTest by adding helper methods to construct agentic user/app context from environment variables. Update all relevant test methods to use these helpers and pass agentic identity where required. Replace Console.WriteLine with xUnit output integration and configure logging for xUnit. Add MartinCostello.Logging.XUnit package for improved test logging. Mark tests requiring special permissions as skipped, and update logging configuration to use "Microsoft.Teams": "Trace". Includes minor test output and environment variable handling improvements.
Replaced explicit string declarations with var for agenticUserId, agenticAppId, and agenticAppBlueprintId in GetConversationAccountWithAgenticProperties and GetAgenticIdentity methods. This change improves code readability and maintains stylistic consistency. No functional changes were made.
rido-min
changed the title
Centralize agentic identity and conversation account construction in new AgenticIdentitiyFromEnv helper. Replace inlined and private methods in test files with calls to this helper. Remove redundant methods from ConversationClientTest. Update TeamsApiClientTests to use ITestOutputHelper for logging and consistently pass agentic identity to TeamsApiClient methods. Improves code reuse, test output, and maintainability.
Explicitly assign Conversation.Id in CoreActivity using the TEST_CONVERSATIONID environment variable, with error handling if not set. This ensures the test message is associated with the correct conversation context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce agentic identity support in ConversationClientTest by adding helper methods to construct agentic user/app context from environment variables. Update all relevant test methods to use these helpers and pass agentic identity where required. Replace Console.WriteLine with xUnit output integration and configure logging for xUnit. Add MartinCostello.Logging.XUnit package for improved test logging. Mark tests requiring special permissions as skipped, and update logging configuration to use "Microsoft.Teams": "Trace". Includes minor test output and environment variable handling improvements.