Skip to content

Revisit LogInformation statements#351

Open
singhk97 wants to merge 2 commits intonext/corefrom
next/revamp-logging
Open

Revisit LogInformation statements#351
singhk97 wants to merge 2 commits intonext/corefrom
next/revamp-logging

Conversation

@singhk97
Copy link
Collaborator

Motivation

We expect developers to have LogInformation statements (and hence greater log levels) enabled in production. And so it should provide just enough information to be achieve the following goals:

  • Be able to identify the issues by tracing logs through internal activity processing pipeline.
  • Get suggestions when incomming activity is not handled.
  • Have access to metadata that helps us, as SDK owners, with debugging.
  • No PIIs should be logged.
  • Logs shouldn't be too verbose or contain redundant information.

Changes

  • Removed BeginScope since it will add the passed context to every log statement, forcing the developer to manually configure filtering in their logging infrastructure.
  • On BotApplication.ProcessAsync add logging of the MSCV & ServiceUrl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant