[code-simplifier] Simplify BuildEvaluators with Array.ConvertAll method group

[Evangelink]

Code Simplification — 2026-06-13

This PR simplifies code introduced in #9071 (MemberConditionAttribute) to improve clarity and conciseness while preserving all functionality.

File Simplified

• src/TestFramework/TestFramework/Attributes/TestMethod/MemberConditionAttribute.cs — Replace manual for-loop in BuildEvaluators with Array.ConvertAll + method group

Improvement Made

Replaced manual array-fill loop with Array.ConvertAll

The BuildEvaluators method allocated a new Func<bool>[], then filled it with a for-loop. Array.ConvertAll expresses the same intent in one line using a method group:

// Before (9 lines)
private Func<bool>[] BuildEvaluators()
{
    var evaluators = new Func<bool>[_conditionMemberNames.Length];
    for (int i = 0; i < _conditionMemberNames.Length; i++)
    {
        evaluators[i] = BuildEvaluator(_conditionMemberNames[i]);
    }
    return evaluators;
}

// After (2 lines)
private Func<bool>[] BuildEvaluators()
    => Array.ConvertAll(_conditionMemberNames, BuildEvaluator);

Array.ConvertAll is available on netstandard2.0, uses a method group instead of a lambda (avoids a delegate wrapper allocation), and makes the transform intent immediately clear.

Changes Based On

Recent changes from:

• Add [MemberCondition] attribute for static-member-based test conditions (#9070) #9071 — Add [MemberCondition] attribute for static-member-based test conditions

Testing

• ✅ Build succeeds (dotnet build src/TestFramework/TestFramework/TestFramework.csproj)
• ✅ No IDE0046 or other style-rule violations
• ✅ No functional changes — behavior is identical (same array output, same exception paths)

Review Focus

Please verify:

• Array.ConvertAll output is equivalent to the for-loop
• Method group BuildEvaluator correctly binds to Func<bool> BuildEvaluator(string)
• No unintended side effects

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Code Simplifier workflow. · 1.7K AIC · ⌖ 34 AIC · [◷]( · ◷)

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/code-simplifier.md@main

• expires on Jun 14, 2026, 2:05 PM UTC

[Copilot]

Pull request overview

This PR performs a small refactor in the MSTest MemberConditionAttribute implementation (TestFramework) by simplifying BuildEvaluators() to use Array.ConvertAll, preserving the existing evaluator-building behavior while making the intent more direct.

Changes:

• Replaced a manual array allocation + for loop in BuildEvaluators() with Array.ConvertAll(_conditionMemberNames, BuildEvaluator).
• Preserved the same exception paths and per-member evaluator construction via the existing BuildEvaluator(string) method.

Show a summary per file

File	Description
src/TestFramework/TestFramework/Attributes/TestMethod/MemberConditionAttribute.cs	Simplifies BuildEvaluators() by converting member-name strings to evaluator delegates via Array.ConvertAll using a method group.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0