Skip to content

[azure-kinect-sensor-sdk] fix imgui delete function - #33231

Closed
jim wang (jimwang118) wants to merge 2 commits into
microsoft:masterfrom
jimwang118:fixazure-kinect-sensor-sdk
Closed

[azure-kinect-sensor-sdk] fix imgui delete function#33231
jim wang (jimwang118) wants to merge 2 commits into
microsoft:masterfrom
jimwang118:fixazure-kinect-sensor-sdk

Conversation

@jimwang118

@jimwang118 jim wang (jimwang118) commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

Fixes #33137

buildtrees\azure-kinect-sensor-sdk\src\v1.4.1-4fd9fcd081.clean\tools\k4aviewer\k4adevicedockcontrol.cpp(336): error C2039: 'SetNextTreeNodeOpen': is not a member of 'ImGui'
buildtrees\azure-kinect-sensor-sdk\src\v1.4.1-4fd9fcd081.clean\tools\k4aviewer\k4asourceselectiondockcontrol.cpp(37): error C2039: 'SetNextTreeNodeOpen': is not a member of 'ImGui'

Replace the deleted function SetNextTreeNodeOpen in imgui with SetNextItemOpen.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jim wang (jimwang118) added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 17, 2023
@jimwang118
jim wang (jimwang118) marked this pull request as ready for review August 17, 2023 09:06
@Adela0814 Mengna Li (Adela0814) added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 17, 2023
@dan-shaw dan-shaw added the depends:upstream-changes Waiting on a change to the upstream project label Aug 17, 2023
@Adela0814 Mengna Li (Adela0814) removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 24, 2023
@jimwang118

Copy link
Copy Markdown
Contributor Author

Upstream PR: microsoft/Azure-Kinect-Sensor-SDK#1945

@jimwang118 jim wang (jimwang118) closed this by deleting the head repository Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[azure-kinect-sensor-sdk] Build error

3 participants