Skip to content

Comments

[cld3] Cleanup, use protobuf config#37495

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
dg0yt:cld3
Mar 18, 2024
Merged

[cld3] Cleanup, use protobuf config#37495
BillyONeal merged 1 commit intomicrosoft:masterfrom
dg0yt:cld3

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Mar 16, 2024

By-product of reviewing #35781.

Not upstreaming the changes due to inactivity. google/cld3#85 (comment).

@jimwang118
Copy link
Contributor

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 18, 2024
@BillyONeal BillyONeal merged commit a23053f into microsoft:master Mar 18, 2024
@BillyONeal
Copy link
Member

Thanks for the fixes! Thanks for checking up with upstream!

@dg0yt dg0yt deleted the cld3 branch March 19, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants