Skip to content

[azure-kinect-sensor-sdk] Fix missing header files and adapt to new version of imgui - #40812

Merged
Victor Romero (vicroms) merged 2 commits into
microsoft:masterfrom
jimwang118:fix-azure-kinect-sensor-sdk
Sep 8, 2024
Merged

[azure-kinect-sensor-sdk] Fix missing header files and adapt to new version of imgui#40812
Victor Romero (vicroms) merged 2 commits into
microsoft:masterfrom
jimwang118:fix-azure-kinect-sensor-sdk

Conversation

@jimwang118

Copy link
Copy Markdown
Contributor

One of the fixes for the #32398 issue.
The following error occurs when installing azure-kinect-sensor-sdk[core,tool].

error: field ‘m_name’ has incomplete type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’}
field ‘m_zoomSliderLabel’ has incomplete type ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’}
error: ‘SetNextTreeNodeOpen’ is not a member of ‘ImGui’; did you mean ‘SetNextItemOpen’?
  1. Add the required header file .
  2. Use the functions in the new version of imgui to replace the old version functions.
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplet:

x64-windows

@jimwang118 jim wang (jimwang118) added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Sep 5, 2024
@WangWeiLin-MV WangWeiLin-MV added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 5, 2024
@jimwang118
jim wang (jimwang118) marked this pull request as ready for review September 5, 2024 07:26
@vicroms
Victor Romero (vicroms) merged commit 59ab5cf into microsoft:master Sep 8, 2024
@jimwang118
jim wang (jimwang118) deleted the fix-azure-kinect-sensor-sdk branch September 9, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants